Linux compiler error that never shown on Visual Studio

let's just admit Visual Studio sux ... ok ?

right now, if you want to host a Private Ragnarok Online server, its just better to choose Debian or CentOS option
the reason is because if you choose Windows Server Edition on VPS,
the cost of running on Windows is often double or triple compare to Linux environment

because of this, programmer like me who write and compile their plugin/source code with Visual Studio,
it will work fine on Windows environment.
But when apply the code on Live server (Linux environment), it will throw non-sensible error

No.1
warning: implicit declaration of function ‘atoi’ [-Wimplicit-function-declaration]

Avoid using atoi like plague !!
in npc scripting its the only script command to convert string into int
yes, this actually working fine with Visual Studio, but on Linux ...

int num = atoi(message); switch(num) { case 0: clif->message(fd, "OFF"); break; default: clif->message(fd, "ON"); break; } <-- change into --> int num = 0; sscanf(message, "%d", &num); switch(num) { case 0: clif->message(fd, "OFF"); break; default: clif->message(fd, "ON"); break; }

No.2
error: a label can only be part of a statement and a declaration is not a statement

Sample
#include "common/hercules.h" #include "map/clif.h" #include "map/atcommand.h" #include "common/strlib.h" #include "plugins/HPMHooking.h" #include "common/HPMDataCheck.h" HPExport struct hplugin_info pinfo = { "test", SERVER_TYPE_MAP, "x.x", HPM_VERSION, }; ACMD(test) { int num; sscanf(message, "%d", &num); switch(num) { case 0: clif->message(fd, "OFF"); return true; default: char msg[CHAT_SIZE_MAX]; safesnprintf(msg, CHAT_SIZE_MAX, "ON %d", num); clif->message(fd, msg); return true; } return true; } HPExport void plugin_init(void) { addAtcommand("test", test); }

default: char msg[CHAT_SIZE_MAX]; safesnprintf(msg, CHAT_SIZE_MAX, "ON %d", num); clif->message(fd, msg); return true; }
this case have to be enclose with curly bracket, like this
ACMD(test) { int num; sscanf(message, "%d", &num); switch(num) { case 0: clif->message(fd, "OFF"); return true; default: { char msg[CHAT_SIZE_MAX]; safesnprintf(msg, CHAT_SIZE_MAX, "ON %d", num); clif->message(fd, msg); return true; } } return true; }

No.3
warning: unused variable ‘len’ [-Wunused-variable]

Sample
#include "common/hercules.h" #include "map/clif.h" #include "common/socket.h" #include "plugins/HPMHooking.h" #include "common/HPMDataCheck.h" HPExport struct hplugin_info pinfo = { "test", SERVER_TYPE_MAP, "x.x", HPM_VERSION, }; static int clif_send_sub_pre(struct block_list **bl, va_list ap) { void *buf = va_arg(ap, void*); int len = va_arg(ap ,int); struct block_list *src_bl = va_arg(ap, struct block_list*); if (src_bl == NULL) return 0; int type = va_arg(ap, int); ShowDebug("%d 0x%x", type, RBUFW(buf, 0)); return 0; } HPExport void plugin_init(void) { addHookPre(clif, send_sub, clif_send_sub_pre); } this is very annoying, because I want to output the value from 4th argument, but the 2nd argument isn't use
on Windows this is fine, but on Linux it throws that error throw off my guard

change
int len = va_arg(ap ,int); <-- change into --> va_arg(ap ,int);

there might be more, will keep this update

Page by page

*mes

sometimes you want to display a long long array list of objects,
for example print out all values from a table
prontera,150,180,5 script test_mes_1 1_F_MARIA,{ .@total = query_sql("SELECT `id`, `name_japanese` FROM `item_db`", .@itemid, .@itemname$); for (.@i = 0; .@i < .@total; ++.@i) mes (.@i +1)+". "+ .@itemid[.@i] +" -> "+ .@itemname$[.@i]; close; } this will throw infinite loop ERROR [Error]: run_script: infinity loop ! [Debug]: Source (NPC): test_mes_1 at prontera (150,180)

the reason is because the script engine has some protection against infinite loop check
conf\map\script.conf
// Maximum number of iterations before considering a loop infinite // Defaults to 2048 check_gotocount: 2048 even if you put a *freeloop there, it might still lag the server

in this case, its better to just display page by page
prontera,152,180,5 script test_mes_2 1_F_MARIA,{ .@itemperpage = 500; .@total = query_sql("SELECT `id`, `name_japanese` FROM `item_db`", .@itemid, .@itemname$); for (.@i = 0; .@i < .@total; .@i += .@itemperpage) { mes "This is Page no."+ (++.@page); for (.@j = .@i; .@j < .@itemperpage + .@i && .@j < .@total; ++.@j) mes (.@i + .@j +1)+". "+ .@itemid[.@j] +" -> "+ .@itemname$[.@j]; next; } close; }

if the *query_sql still cause lag, have to use OFFSET
prontera,154,180,5 script test_mes_3 1_F_MARIA,{ .@itemperpage = 500; query_sql "SELECT COUNT(1) FROM `item_db`", .@total; while (true) { mes "This is Page no."+ (.@page +1); .@nb = query_sql("SELECT `id`, `name_japanese` FROM `item_db` LIMIT "+ .@itemperpage +" OFFSET "+(.@itemperpage * .@page), .@itemid, .@itemname$); for (.@i = 0; .@i < .@nb; ++.@i) mes (.@page * .@itemperpage + .@i +1)+". "+ .@itemid[.@i] +" -> "+ .@itemname$[.@i]; if (.@page < .@total / .@itemperpage) next; else close; ++.@page; } close; }

and this is with page input for your amusement :)
prontera,156,180,5 script test_mes_4 1_F_MARIA,{ .@itemperpage = 500; query_sql "SELECT COUNT(1) FROM `item_db`", .@total; while (true) { mes "This is Page no."+ (.@page +1); .@nb = query_sql("SELECT `id`, `name_japanese` FROM `item_db` LIMIT "+ .@itemperpage +" OFFSET "+(.@itemperpage * .@page), .@itemid, .@itemname$); for (.@i = 0; .@i < .@nb; ++.@i) mes (.@page * .@itemperpage + .@i +1)+". "+ .@itemid[.@i] +" -> "+ .@itemname$[.@i]; next; switch(select((.@page < .@total / .@itemperpage)? "Next Page" : "", (.@page > 0)? "Previous Page" : "", "Select Page")) { case 1: ++.@page; break; case 2: --.@page; break; case 3: input .@num, 1, .@total / .@itemperpage +1; .@page = .@num -1; break; } } close; }


*select

same as above prontera,150,178,5 script test_select_1 1_F_MARIA,{ .@total = query_sql("SELECT `id`, `name_japanese` FROM `item_db`", .@itemid, .@itemname$); for (.@i = 0; .@i < .@total; ++.@i) .@menu$ += .@itemid[.@i] +" -> "+ .@itemname$[.@i] +":"; .@s = select(.@menu$) -1; mes .@itemid[.@s] +" -> "+ F_MesItemInfo(.@itemid[.@index]); close; } this will throw infinity loop ERROR
even if you put a LIMIT syntax prontera,152,178,5 script test_select_2 1_F_MARIA,{ .@total = query_sql("SELECT `id`, `name_japanese` FROM `item_db` LIMIT 500", .@itemid, .@itemname$); for (.@i = 0; .@i < .@total; ++.@i) .@menu$ += .@itemid[.@i] +" -> "+ .@itemname$[.@i] +":"; .@s = select(.@menu$) -1; mes .@itemid[.@s] +" -> "+ F_MesItemInfo(.@itemid[.@index]); close; } this will throw menu length too long / too many options ERROR
[Warning]: NPC Menu too long! (source:sdfkdflk / length:9896) [Warning]: buildin_select: Too many options specified (current=500, max=254). [Debug]: Source (NPC): sdfkdflk at prontera (150,183)
this is because the maximum limit of menu length in string (eg: *getstrlen) is 2047
and the maximum limit of menu options is 254
src\map\script.h
#define MAX_MENU_OPTIONS 0xFF #define MAX_MENU_LENGTH 0x800 and I don't recommend changing this, as you also have to change the packet structure etc ...

so the only way to remedy this ... is again ... page by page prontera,154,178,5 script test_select_3 1_F_MARIA,{ .@itemperpage = 50; .@total = query_sql("SELECT `id`, `name_japanese` FROM `item_db`", .@itemid, .@itemname$); freeloop true; .@maxpage = .@total / .@itemperpage + (.@total % .@itemperpage > 0); for (.@i = 0; .@i < .@maxpage; ++.@i) { .@menu$[.@i] = (.@i)? "Previous Page:" : ":"; for (.@j = 0; .@j < .@itemperpage; ++.@j) .@menu$[.@i] += .@itemname$[.@k++] +":"; if (.@i < .@maxpage -1) .@menu$[.@i] += "Next Page"; } while (true) { .@s = select(.@menu$[.@page]) -1; if (.@s == 0) --.@page; else if (.@s == .@itemperpage +1) ++.@page; else break; } .@index = .@page * .@itemperpage + .@s -1; mes .@itemid[.@index] +" -> "+ F_MesItemInfo(.@itemid[.@index]); close; }

if the query_sql still cause lag, have to use OFFSET
prontera,156,178,5 script test_select_4 1_F_MARIA,{ .@itemperpage = 50; query_sql "SELECT COUNT(1) FROM `item_db`", .@total; .@maxpage = .@total / .@itemperpage + (.@total % .@itemperpage > 0); while (true) { .@nb = query_sql("SELECT `id`, `name_japanese` FROM `item_db` LIMIT "+ .@itemperpage +" OFFSET "+(.@itemperpage * .@page), .@itemid, .@itemname$); .@menu$ = (.@page)? "Previous Page:" : ":"; for (.@i = 0; .@i < .@nb; ++.@i) .@menu$ += .@itemname$[.@i] +":"; if (.@page < .@maxpage -1) .@menu$ += "Next Page"; .@s = select(.@menu$) -1; if (.@s == 0) --.@page; else if (.@s == .@itemperpage +1) ++.@page; else break; } .@index = .@s -1; mes .@itemid[.@index] +" -> "+ F_MesItemInfo(.@itemid[.@index]); close; }

and the page select display for your amusement :)
prontera,158,178,5 script test_select_5 1_F_MARIA,{ L_start: .@itemperpage = 50; query_sql "SELECT COUNT(1) FROM `item_db`", .@total; .@maxpage = .@total / .@itemperpage + (.@total % .@itemperpage > 0); while (true) { .@nb = query_sql("SELECT `id`, `name_japanese` FROM `item_db` LIMIT "+ .@itemperpage +" OFFSET "+(.@itemperpage * .@page), .@itemid, .@itemname$); .@menu$ = "Back:Select Page:"; .@menu$ += (.@page)? "Previous Page:" : ":"; for (.@i = 0; .@i < .@nb; ++.@i) .@menu$ += .@itemname$[.@i] +":"; if (.@page < .@maxpage -1) .@menu$ += "Next Page"; mes "This is Page No."+(.@page +1); .@s = select(.@menu$) -1; if (.@s == 0) goto L_start; else if (.@s == 1) { input .@num, 1, .@total / .@itemperpage +1; .@page = .@num -1; } else if (.@s == 2) --.@page; else if (.@s == .@itemperpage +3) ++.@page; else break; mesclear; } .@index = .@s -3; mes .@itemid[.@index] +" -> "+ F_MesItemInfo(.@itemid[.@index]); close; }

External Links:
Help - Array in menu