Compare Instance script between rAthena & Hercules

Hercules
prontera,155,180,0 script Test Instance 1_F_MARIA,{ if (has_instance2("guild_vs2") >= 0) instance_destroy has_instance2("guild_vs2"); if ((.@ins = instance_create( "Test Instance", getcharid(CHAR_ID_ACCOUNT), IOT_CHAR)) < 0) { mes "error : "+ .@ins; close; } if (!getstrlen(instance_attachmap("guild_vs2", .@ins, true, .@ins +"INST" ))) { mes "error : 5"; instance_destroy .@ins; close; } instance_set_timeout 3600, 15, .@ins; instance_init .@ins; warp has_instance("guild_vs2"), 49,49; end; } guild_vs2,49,49,5 script test dialog 1_F_MARIA,{ dispbottom strnpcinfo(NPC_MAP); mesf "%d monsters on this map", 'amount; next; select "Destroy"; instance_destroy; end; OnInstanceInit: monster instance_mapname("guild_vs2"), 49,49, "--ja--", PORING, 10, instance_npcname(strnpcinfo(NPC_NAME))+"::OnMobDead"; 'amount = 10; end; OnMobDead: --'amount; if (!'amount) { instance_announce -1, "all monster killed", bc_map; sleep 1000; instance_destroy instance_id(); } end; }

1. Hercules has more instance related script commands, but also make this more flexible and versatile once you learn to use them
   
   • Hercules has *instance_attach script command, make sure this script command is added AFTER *instance_init if you want the script to do some other stuffs inside the instance during the registration phase.
   • Hercules has to emulate the map name with *instance_attachmap if the map name doesn't follow the syntax <number>@<5 string limit>
2. Hercules instance ID start from 0, rathena instance ID start from 1
   
   • Make sure the instance_announce is set to -1

-------------------------------

rAthena
// db/import/instance_db.yml Body: - Id: 34 Name: Test Instance TimeLimit: 3600 IdleTimeOut: 15 Enter: Map: guild_vs2 X: 49 Y: 49
prontera,155,180,0 script Test Instance 1_F_MARIA,{ if (instance_id(IM_PARTY)) { instance_destroy instance_id(IM_PARTY); close; } if (instance_create("Test Instance", IM_PARTY) < 0) { mes "failed to create instance"; close; } instance_enter "Test Instance"; end; } guild_vs2,49,49,5 script test dialog 1_F_MARIA,{ dispbottom strnpcinfo(4); mes sprintf("%d monsters on this map", 'amount); next; select "Destroy"; instance_destroy; end; OnInstanceInit: monster instance_mapname("guild_vs2"), 49,49, "--ja--", 1002, 10, instance_npcname(strnpcinfo(0))+"::OnMobDead"; 'amount = 10; end; OnMobDead: --'amount; if ( !'amount ) { instance_announce 0, "all monster killed", bc_map; sleep 2000; instance_destroy; } end; }

1. rathena has instance_db.yml file ... make sure you add these line then @reloadinstancedb 
• dealing with .yml file in rathena is really a headche, sometimes it spits error that doesn't make sense, and all you have to do is add/remove a single space or new line ...
  
2. rAthena relies on instance_id(IM_type) to know which instance ID the player belongs in.
   
3. rathena has much less instance related script command, making rathena instance script easier to learn, but there is a drawback
   
   • not as flexible as hercules having *instance_timeout script command ... this value is hardcoded into database so all party has to use the same timeout value
4.  rathena instance ID start from 1, hercules instance ID start from 0
   • make sure the instance_announce is set to 0 

rAthena *instance_enter doesn't work with IM_NONE .... wait is rathena only works with IM_PARTY, all other types doesn't work at this moment

Note: I didn't file a bug report because I was assuming they going to fix in this pull request rAthena has a bug that prevents you from entering multiple instance
34,Instance ONE,3600,15,guild_vs1,49,49 35,Instance TWO,3600,15,guild_vs3,49,49
prontera,150,180,0 script Check Instance 1_F_MARIA,{ OnClick: dispbottom strcharinfo(3); dispbottom instance_id() +""; // this line sux ... but I saw a pull request addressing this issue end; OnInit: bindatcmd "test", strnpcinfo(0)+"::OnClick"; end; } prontera,155,180,0 script Instance ONE 1_F_MARIA,{ if ( getstrlen( instance_mapname("guild_vs1") ) ) { instance_enter "Instance ONE"; end; } if ( instance_create( "Instance ONE", IM_PARTY ) < 0 ) { mes "failed to create instance"; close; } instance_enter "Instance ONE"; end; } prontera,158,180,0 script Instance TWO 1_F_MARIA,{ if ( getstrlen( instance_mapname("guild_vs2") ) ) { instance_enter "Instance TWO"; end; } if ( instance_create( "Instance TWO", IM_GUILD ) < 0 ) { mes "failed to create instance"; close; } instance_enter "Instance TWO"; end; }
Player A has same party with player B.
Player A has same guild with player C.

Player B create Instance ONE for party.
Player C create Instance TWO for guild.

Player A supposedly can go in both instance, but player A can only go to the party instance, not the guild
Hercules doesn't suffer from this issue.
prontera,150,180,0 script Check Instance 1_F_MARIA,{ OnClick: dispbottom strcharinfo(3); dispbottom instance_id() +""; // this script command is useless in hercules, always return -1 on non-instanced npc. An instanced npc don't need to use this script command anyway dispbottom has_instance2("guild_vs1") +""; dispbottom has_instance2("guild_vs2") +""; end; OnInit: bindatcmd "test", strnpcinfo(0)+"::OnClick"; end; } prontera,155,180,0 script Instance ONE 1_F_MARIA,{ if ( has_instance2("guild_vs1") >= 0 ) { warp has_instance("guild_vs1"), 49,49; end; } if ( ( .@ins = instance_create( "Instance ONE", getcharid(CHAR_ID_PARTY), IOT_PARTY ) ) < 0 ) { mes "error : "+ .@ins; close; } if ( !getstrlen( instance_attachmap( "guild_vs1", .@ins, true, .@ins +"INS1" ) ) ) { mes "error : 5"; instance_destroy .@ins; close; } instance_set_timeout 3600, 15, .@ins; instance_init .@ins; warp has_instance("guild_vs1"), 49,49; end; } prontera,158,180,0 script Instance TWO 1_F_MARIA,{ if ( has_instance2("guild_vs2") >= 0 ) { warp has_instance("guild_vs2"), 49,49; end; } if ( ( .@ins = instance_create( "Instance ONE", getcharid(CHAR_ID_GUILD), IOT_GUILD ) ) < 0 ) { mes "error : "+ .@ins; close; } if ( !getstrlen( instance_attachmap( "guild_vs2", .@ins, true, .@ins +"INS2" ) ) ) { mes "error : 5"; instance_destroy .@ins; close; } instance_set_timeout 3600, 15, .@ins; instance_init .@ins; warp has_instance("guild_vs2"), 49,49; end; }

External Links

Help learning instance and how it works - rAthena & Hercules
Doubt about instance_create command