The reason why *getmapxy uses UNITTYPE constants

Ever wonder why *getmapxy introduced a new constant using the same value as *getunittype ?

That reason is because I wanted to allow *getmapxy can retrieve the coordinate of the unit

You see, the *getunitdata script command can only return integer value,
thus the map name return as string is not recommended
- although *getmonsterinfo with MOB_NAME can return string while others return integer...
--- I wonder why aleos never think about it ?

And ... with my Pull Request merge, Hercules can do like this
OnPCDieEvent: if ( !killerrid ) end; getmapxy .@map$, .@x, .@y, getunittype(killerrid), killerrid; dispbottom .@map$ +" "+ .@x +" "+ .@y; end; however this cannot be done in rAthena

so rAthena has to stuck with *getunitdata
the worst thing is it doesn't return map name, it return map ID
and have to use another script command *mapid2name to turn map ID into map name
OnPCDieEvent: if ( !killerrid ) end; switch ( getunittype(killerrid) ) { // case BL_PC: default: getmapxy .@map$, .@x, .@y, BL_PC, killerrid; dispbottom .@map$ +" "+ .@x +" "+ .@y; break; case BL_MOB: getunitdata killerrid, .@unitdata; dispbottom mapid2name(.@unitdata[UMOB_MAPID]) +" "+ .@unitdata[UMOB_X] +" "+ .@unitdata[UMOB_Y]; break; case BL_PET: getunitdata killerrid, .@unitdata; dispbottom mapid2name(.@unitdata[UPET_MAPID]) +" "+ .@unitdata[UPET_X] +" "+ .@unitdata[UPET_Y]; break; case BL_HOM: getunitdata killerrid, .@unitdata; dispbottom mapid2name(.@unitdata[UHOM_MAPID]) +" "+ .@unitdata[UHOM_X] +" "+ .@unitdata[UHOM_Y]; break; case BL_MER: getunitdata killerrid, .@unitdata; dispbottom mapid2name(.@unitdata[UMER_MAPID]) +" "+ .@unitdata[UMER_X] +" "+ .@unitdata[UMER_Y]; break; case BL_ELEM: getunitdata killerrid, .@unitdata; dispbottom mapid2name(.@unitdata[UELE_MAPID]) +" "+ .@unitdata[UELE_X] +" "+ .@unitdata[UELE_Y]; break; case BL_NPC: getunitdata killerrid, .@unitdata; dispbottom mapid2name(.@unitdata[UNPC_MAPID]) +" "+ .@unitdata[UNPC_X] +" "+ .@unitdata[UNPC_Y]; break; } end;


Update, it seems rAthena has updated *getmapxy script command, and changed UNITTYPE_ into BL_
however it still couldn't search with BL_MOB type, so it doesn't change much

External Links:

https://github.com/HerculesWS/Hercules/pull/871
https://github.com/rathena/rathena/issues/3100